Merge pull request #1653 from evoL/evol/push-qlpuxltsltwt

fix: never use a transition on the shell route

lib/config/routes.dart

@@ -87,7 +87,10 @@ abstract class AppRoutes {
       ),
     ),
     ShellRoute(
-      pageBuilder: (context, state, child) => defaultPageBuilder(
+      // Never use a transition on the shell route. Changing the PageBuilder
+      // here based on a MediaQuery causes the child to briefly be rendered
+      // twice with the same GlobalKey, blowing up the rendering.
+      pageBuilder: (context, state, child) => noTransitionPageBuilder(
         context,
         state,
         FluffyThemes.isColumnMode(context) &&
@@ -458,17 +461,24 @@ abstract class AppRoutes {
     ),
   ];
 
+  static Page noTransitionPageBuilder(
+    BuildContext context,
+    GoRouterState state,
+    Widget child,
+  ) =>
+      NoTransitionPage(
+        key: state.pageKey,
+        restorationId: state.pageKey.value,
+        child: child,
+      );
+
   static Page defaultPageBuilder(
     BuildContext context,
     GoRouterState state,
     Widget child,
   ) =>
       FluffyThemes.isColumnMode(context)
-          ? NoTransitionPage(
+          ? noTransitionPageBuilder(context, state, child)
-              key: state.pageKey,
-              restorationId: state.pageKey.value,
-              child: child,
-            )
           : MaterialPage(
               key: state.pageKey,
               restorationId: state.pageKey.value,