chore: Avoid unnecessary lambdas

analysis_options.yaml

@@ -17,6 +17,8 @@ linter:
     - unnecessary_statements
     - avoid_bool_literals_in_conditional_expressions
     - prefer_single_quotes
+    - prefer_const_declarations
+    - unnecessary_lambdas
 
 analyzer:
   plugins:

lib/pages/chat/chat_event_list.dart

@@ -155,8 +155,7 @@ class ChatEventList extends StatelessWidget {
                 highlightMarker:
                     controller.scrollToEventIdMarker == event.eventId,
                 onSelect: controller.onSelectMessage,
-                scrollToEventId: (String eventId) =>
+                scrollToEventId: controller.scrollToEventId,
-                    controller.scrollToEventId(eventId),
                 longPressSelect: controller.selectedEvents.isNotEmpty,
                 selected: controller.selectedEvents.any(
                   (e) => e.eventId == event.eventId,
@@ -164,7 +163,7 @@ class ChatEventList extends StatelessWidget {
                 singleSelected:
                     controller.selectedEvents.singleOrNull?.eventId ==
                     event.eventId,
-                onEdit: () => controller.editSelectedEventAction(),
+                onEdit: controller.editSelectedEventAction,
                 timeline: timeline,
                 displayReadMarker:
                     i > 0 && controller.readMarkerEventId == event.eventId,

lib/pages/chat/events/message_content.dart

@@ -207,7 +207,7 @@ class MessageContent extends StatelessWidget {
                   .split(';')
                   .first
                   .split(',')
-                  .map((s) => double.tryParse(s))
+                  .map(double.tryParse)
                   .toList();
               if (latlong.length == 2 &&
                   latlong.first != null &&

lib/pages/chat/events/message_reactions.dart

@@ -66,7 +66,7 @@ class MessageReactions extends StatelessWidget {
                 if (evt != null) {
                   showFutureLoadingDialog(
                     context: context,
-                    future: () => evt.redactEvent(),
+                    future: evt.redactEvent,
                   );
                 }
               } else {

lib/pages/chat/events/poll.dart

@@ -25,7 +25,7 @@ class PollWidget extends StatelessWidget {
   });
 
   void _endPoll(BuildContext context) =>
-      showFutureLoadingDialog(context: context, future: () => event.endPoll());
+      showFutureLoadingDialog(context: context, future: event.endPoll);
 
   void _toggleVote(BuildContext context, String answerId, int maxSelection) {
     final userId = event.room.client.userID!;

lib/pages/chat/recording_view_model.dart

@@ -145,9 +145,7 @@ class RecordingViewModelState extends State<RecordingViewModel> {
   }
 
   void cancel() {
-    setState(() {
+    setState(_reset);
-      _reset();
-    });
   }
 
   void pause() {

lib/pages/chat_access_settings/chat_access_settings_page.dart

@@ -181,9 +181,7 @@ class ChatAccessSettingsPageView extends StatelessWidget {
                         return const SizedBox.shrink();
                       }
                       localAddresses.remove(room.canonicalAlias);
-                      localAddresses.removeWhere(
+                      localAddresses.removeWhere(altAliases.contains);
-                        (alias) => altAliases.contains(alias),
-                      );
                       return Column(
                         mainAxisSize: .min,
                         children: localAddresses

lib/pages/chat_list/chat_list_body.dart

@@ -35,7 +35,7 @@ class ChatListViewBody extends StatelessWidget {
         key: ValueKey(activeSpace),
         spaceId: activeSpace,
         onBack: controller.clearActiveSpace,
-        onChatTab: (room) => controller.onChatTap(room),
+        onChatTab: controller.onChatTap,
         activeChat: controller.activeChat,
       );
     }
@@ -123,7 +123,7 @@ class ChatListViewBody extends StatelessWidget {
                   if (!controller.isSearchMode &&
                       AppSettings.showPresences.value)
                     GestureDetector(
-                      onLongPress: () => controller.dismissStatusList(),
+                      onLongPress: controller.dismissStatusList,
                       child: StatusMessageList(
                         onStatusEdit: controller.setStatus,
                       ),

lib/pages/dialer/dialer.dart

@@ -194,9 +194,7 @@ class MyCallingPage extends State<Calling> {
     call.onCallStateChanged.stream.listen(_handleCallState);
     call.onCallEventChanged.stream.listen((event) {
       if (event == CallStateChange.kFeedsChanged) {
-        setState(() {
+        setState(call.tryRemoveStopedStreams);
-          call.tryRemoveStopedStreams();
-        });
       } else if (event == CallStateChange.kLocalHoldUnhold ||
           event == CallStateChange.kRemoteHoldUnhold) {
         setState(() {});

lib/utils/matrix_sdk_extensions/device_extension.dart

@@ -4,10 +4,10 @@ import 'package:matrix/matrix.dart';
 
 IconData _getIconFromName(String displayname) {
   final name = displayname.toLowerCase();
-  if ({'android'}.any((s) => name.contains(s))) {
+  if ({'android'}.any(name.contains)) {
     return Icons.phone_android_outlined;
   }
-  if ({'ios', 'ipad', 'iphone', 'ipod'}.any((s) => name.contains(s))) {
+  if ({'ios', 'ipad', 'iphone', 'ipod'}.any(name.contains)) {
     return Icons.phone_iphone_outlined;
   }
   if ({
@@ -19,16 +19,10 @@ IconData _getIconFromName(String displayname) {
     '/_matrix',
     'safari',
     'opera',
-  }.any((s) => name.contains(s))) {
+  }.any(name.contains)) {
     return Icons.web_outlined;
   }
-  if ({
+  if ({'desktop', 'windows', 'macos', 'linux', 'ubuntu'}.any(name.contains)) {
-    'desktop',
-    'windows',
-    'macos',
-    'linux',
-    'ubuntu',
-  }.any((s) => name.contains(s))) {
     return Icons.desktop_mac_outlined;
   }
   return Icons.device_unknown_outlined;

lib/utils/stream_extension.dart

@@ -35,7 +35,7 @@ extension StreamExtension on Stream {
     };
     final subscription = listen(
       (_) => onMessage?.call(),
-      onDone: () => controller.close(),
+      onDone: controller.close,
       onError: (e, s) => controller.addError(e, s),
     );
     // add proper cleanup to the subscription and the controller, to not memory leak

lib/utils/uia_request_manager.dart

@@ -105,9 +105,7 @@ extension UiaRequestManager on MatrixState {
 
           launchUrl(url, mode: LaunchMode.inAppBrowserView);
           final completer = Completer();
-          final listener = AppLifecycleListener(
+          final listener = AppLifecycleListener(onResume: completer.complete);
-            onResume: () => completer.complete(),
-          );
           await completer.future;
           listener.dispose();
 

lib/utils/url_launcher.dart

@@ -66,7 +66,7 @@ class UrlLauncher {
             .split(';')
             .first
             .split(',')
-            .map((s) => double.tryParse(s))
+            .map(double.tryParse)
             .toList();
         if (latlong.length == 2 &&
             latlong.first != null &&